forked from magento/magento2
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] [Resolved : limiter float too generic] #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lasses magento#15693 - Merge Pull Request magento#15693 from dmytro-ch/magento2:fix/2.1-minor-issues-in-ui-export-converters - Merged commits: 1. b4171a1
- Changed disply to display - Changed addtional to additional
…ento#15716 - Merge Pull Request magento#15716 from dverkade/magento2:2.1-Fix-typos - Merged commits: 1. e0544c2
…ata in DocBlock magento#15719 - Merge Pull Request magento#15719 from rogyar/magento2:2.1-wishlist-wrong-imagedata-return - Merged commits: 1. 03d45ee
…nces magento#15739 - Merge Pull Request magento#15739 from vijay-wagento/magento2:2.1-develop-PR-port-15485 - Merged commits: 1. 8c6ed20
…widget magento#15736 - Merge Pull Request magento#15736 from vijay-wagento/magento2:2.1-develop-PR-port-15351 - Merged commits: 1. 02453f6
- Merge Pull Request magento#15724 from vgelani/magento2:2.1-develop-PR-port-15416 - Merged commits: 1. d2f5f02
…oDo UI magento#15725 - Merge Pull Request magento#15725 from vgelani/magento2:2.1-develop-PR-port-15421 - Merged commits: 1. 4e3a7fe
There is an error in Module Manager (http://store.com/setup/index.php/moduleGrid/modules) if some module has no "moduleName" property: ``` { "name": "amzn\/amazon-pay-and-login-magento-2-module", "type": "magento2-module", "version": "2.0.4" } ```
- Merge Pull Request magento#15573 from rogyar/magento2:2.1-docblock-typo-fixes - Merged commits: 1. 371bb07
- Merge Pull Request magento#15805 from chirag-wagento/magento2:2.1-develop-PR-port-15790 - Merged commits: 1. b01558a
…nces magento#15810 - Merge Pull Request magento#15810 from DanielRuf/magento2:2.1-develop-PR-port-15485 - Merged commits: 1. f7893a4
- Merge Pull Request magento#15807 from hitesh-wagento/magento2:2.1-develop-PR-port-15792 - Merged commits: 1. e2fd050
…magento#15803 - Merge Pull Request magento#15803 from vijay-wagento/magento2:2.1-develop-PR-port-15795 - Merged commits: 1. 96b8870
- Merge Pull Request magento#15814 from viral-wagento/magento2:feature-fix-typo-for-setCateroryIds - Merged commits: 1. ea51428
…ist magento#15816 - Merge Pull Request magento#15816 from viral-wagento/magento2:feature-misleading-data-container-in-productlist - Merged commits: 1. 1a94fd8
…ento#15817 - Merge Pull Request magento#15817 from rahul-kachhadiya/magento2:2.1-develop-PR-port-15269 - Merged commits: 1. 16b9f72
- Merge Pull Request magento#15756 from vijay-wagento/magento2:2.1-develop-PR-port-15211 - Merged commits: 1. 8f4f052 2. 13dc017
Accepted Public Pull Requests: - magento#15725: [Backport] Updated font-size variable and standardize #ToDo UI (by @vgelani) - magento#15724: [Backport] Moved css from media #TODO (by @vgelani) - magento#15736: [Backwardport] Refactor javascript code of button split widget (by @vijay-wagento) - magento#15739: [Backport] fix: support multiple minisearch widget instances (by @vijay-wagento) - magento#15719: [Backport 2.1] Fixed return type of wishlist's getImageData in DocBlock (by @rogyar) - magento#15716: [BACKPORT 2.1 magento#15695] Fixed a couple of typos (by @dverkade) - magento#15803: [Backport] Remove double semicolon from the style sheets. (by @vijay-wagento) - magento#15807: [Backport] [Code improvement] (by @hitesh-wagento) - magento#15810: [Backport] fix: support multiple minisearch widget instances (by @DanielRuf) - magento#15805: [Backport] Make necessary space. #5 (by @chirag-wagento) Fixed GitHub Issues: - magento#15354: Refactor javascript code of button split widget call js component (reported by @amittiwari024) has been fixed in magento#15736 by @vijay-wagento in 2.1-develop branch Related commits: 1. 02453f6
Accepted Public Pull Requests: - magento#15756: [Backport] Error 500 in Module Manager (by @vijay-wagento) - magento#15817: [Backport] Fix typo in Image::open exception message (by @rahul-kachhadiya) - magento#15816: [BackPort]15319 : misleading data-container in product list (by @viral-wagento) - magento#15814: [Backport] fix typo for setCateroryIds (by @viral-wagento) - magento#15573: [Backport] Docblock typo fixes (by @rogyar) - magento#15693: [Backport 2.1] Fix minor issues in ui export converter classes (by @dmytro-ch) Fixed GitHub Issues: - magento#15192: Module Manager module grid is not working Magento 2.2.4 (reported by @jignesh-baldha) has been fixed in magento#15756 by @vijay-wagento in 2.1-develop branch Related commits: 1. 8f4f052 2. 13dc017 - magento#15319: misleading data-container in product list (reported by @DanielRuf) has been fixed in magento#15816 by @viral-wagento in 2.1-develop branch Related commits: 1. 1a94fd8 - magento#15590: Typo in tests / setCateroryIds([]) (reported by @kmddevdani) has been fixed in magento#15814 by @viral-wagento in 2.1-develop branch Related commits: 1. ea51428
hitesh-wagento
pushed a commit
that referenced
this pull request
Jul 14, 2018
[Forwardport] Fix newsletter subscription behaviour for registered customer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#15878
.limiter should have the same parent selectors like .pages to prevent clashes between styles and layouts
Description
Added selector for floating the element
.limiter
Fixed Issues (if relevant)
Manual testing scenarios
.limiter
and.pages
Actual Result
.limiter
is too generic and is used as single selector for floating the elementExpected Result
.limiter
should have the same parent selectors like .pages to prevent clashes between styles and layoutsContribution checklist