Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [Resolved : limiter float too generic] #9

Merged
merged 55 commits into from
Jun 6, 2018

Conversation

hitesh-wagento
Copy link
Owner

Original Pull Request

magento#15878

.limiter should have the same parent selectors like .pages to prevent clashes between styles and layouts

Description

Added selector for floating the element .limiter

Fixed Issues (if relevant)

  1. magento/magento2#limiter float too generic magento/magento2#15323: Issue title limiter float too generic

Manual testing scenarios

  1. inspect toolbar in product list
  2. compare styles of .limiter and .pages

Actual Result

.limiter is too generic and is used as single selector for floating the element

Expected Result

.limiter should have the same parent selectors like .pages to prevent clashes between styles and layouts

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

gelanivishal and others added 30 commits May 25, 2018 09:08
…lasses magento#15693

 - Merge Pull Request magento#15693 from dmytro-ch/magento2:fix/2.1-minor-issues-in-ui-export-converters
 - Merged commits:
   1. b4171a1
- Changed disply to display
- Changed addtional to additional
…ento#15716

 - Merge Pull Request magento#15716 from dverkade/magento2:2.1-Fix-typos
 - Merged commits:
   1. e0544c2
…ata in DocBlock magento#15719

 - Merge Pull Request magento#15719 from rogyar/magento2:2.1-wishlist-wrong-imagedata-return
 - Merged commits:
   1. 03d45ee
…nces magento#15739

 - Merge Pull Request magento#15739 from vijay-wagento/magento2:2.1-develop-PR-port-15485
 - Merged commits:
   1. 8c6ed20
…widget magento#15736

 - Merge Pull Request magento#15736 from vijay-wagento/magento2:2.1-develop-PR-port-15351
 - Merged commits:
   1. 02453f6
 - Merge Pull Request magento#15724 from vgelani/magento2:2.1-develop-PR-port-15416
 - Merged commits:
   1. d2f5f02
…oDo UI magento#15725

 - Merge Pull Request magento#15725 from vgelani/magento2:2.1-develop-PR-port-15421
 - Merged commits:
   1. 4e3a7fe
There is an error in Module Manager (http://store.com/setup/index.php/moduleGrid/modules) if some module has no "moduleName" property:
```
{
  "name": "amzn\/amazon-pay-and-login-magento-2-module",
  "type": "magento2-module",
  "version": "2.0.4"
}
```
 - Merge Pull Request magento#15573 from rogyar/magento2:2.1-docblock-typo-fixes
 - Merged commits:
   1. 371bb07
magento-engcom-team and others added 25 commits June 5, 2018 01:20
 - Merge Pull Request magento#15805 from chirag-wagento/magento2:2.1-develop-PR-port-15790
 - Merged commits:
   1. b01558a
…nces magento#15810

 - Merge Pull Request magento#15810 from DanielRuf/magento2:2.1-develop-PR-port-15485
 - Merged commits:
   1. f7893a4
 - Merge Pull Request magento#15807 from hitesh-wagento/magento2:2.1-develop-PR-port-15792
 - Merged commits:
   1. e2fd050
…magento#15803

 - Merge Pull Request magento#15803 from vijay-wagento/magento2:2.1-develop-PR-port-15795
 - Merged commits:
   1. 96b8870
 - Merge Pull Request magento#15814 from viral-wagento/magento2:feature-fix-typo-for-setCateroryIds
 - Merged commits:
   1. ea51428
…ist magento#15816

 - Merge Pull Request magento#15816 from viral-wagento/magento2:feature-misleading-data-container-in-productlist
 - Merged commits:
   1. 1a94fd8
…ento#15817

 - Merge Pull Request magento#15817 from rahul-kachhadiya/magento2:2.1-develop-PR-port-15269
 - Merged commits:
   1. 16b9f72
 - Merge Pull Request magento#15756 from vijay-wagento/magento2:2.1-develop-PR-port-15211
 - Merged commits:
   1. 8f4f052
   2. 13dc017
Accepted Public Pull Requests:
 - magento#15725: [Backport] Updated font-size variable and standardize #ToDo UI (by @vgelani)
 - magento#15724: [Backport] Moved css from media #TODO (by @vgelani)
 - magento#15736: [Backwardport] Refactor javascript code of  button split widget (by @vijay-wagento)
 - magento#15739: [Backport] fix: support multiple minisearch widget instances (by @vijay-wagento)
 - magento#15719: [Backport 2.1] Fixed return type of wishlist's getImageData in DocBlock (by @rogyar)
 - magento#15716: [BACKPORT 2.1 magento#15695] Fixed a couple of typos (by @dverkade)
 - magento#15803: [Backport] Remove double semicolon from the style sheets. (by @vijay-wagento)
 - magento#15807: [Backport] [Code improvement] (by @hitesh-wagento)
 - magento#15810: [Backport] fix: support multiple minisearch widget instances (by @DanielRuf)
 - magento#15805: [Backport] Make necessary space. #5 (by @chirag-wagento)


Fixed GitHub Issues:
 - magento#15354: Refactor javascript code of button split widget call js component (reported by @amittiwari024) has been fixed in magento#15736 by @vijay-wagento in 2.1-develop branch
   Related commits:
     1. 02453f6
Accepted Public Pull Requests:
 - magento#15756: [Backport] Error 500 in Module Manager (by @vijay-wagento)
 - magento#15817: [Backport] Fix typo in Image::open exception message (by @rahul-kachhadiya)
 - magento#15816: [BackPort]15319 : misleading data-container in product list (by @viral-wagento)
 - magento#15814: [Backport] fix typo for setCateroryIds (by @viral-wagento)
 - magento#15573: [Backport] Docblock typo fixes (by @rogyar)
 - magento#15693: [Backport 2.1] Fix minor issues in ui export converter classes (by @dmytro-ch)


Fixed GitHub Issues:
 - magento#15192: Module Manager module grid is not working Magento 2.2.4 (reported by @jignesh-baldha) has been fixed in magento#15756 by @vijay-wagento in 2.1-develop branch
   Related commits:
     1. 8f4f052
     2. 13dc017

 - magento#15319: misleading data-container in product list (reported by @DanielRuf) has been fixed in magento#15816 by @viral-wagento in 2.1-develop branch
   Related commits:
     1. 1a94fd8

 - magento#15590: Typo in tests / setCateroryIds([]) (reported by @kmddevdani) has been fixed in magento#15814 by @viral-wagento in 2.1-develop branch
   Related commits:
     1. ea51428
@hitesh-wagento hitesh-wagento merged commit 2f13af3 into 2.1-develop Jun 6, 2018
hitesh-wagento pushed a commit that referenced this pull request Jul 14, 2018
[Forwardport] Fix newsletter subscription behaviour for registered customer.
hitesh-wagento pushed a commit that referenced this pull request Aug 29, 2018
@hitesh-wagento hitesh-wagento deleted the 2.1-develop-PR-port-15878 branch September 6, 2018 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.